Skip to content

bypass smbtest to unblock integration tests #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bypass smbtest to unblock integration tests #356

wants to merge 1 commit into from

Conversation

@Zhupku
Copy link

@Zhupku Zhupku commented Sep 23, 2024 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

What this PR does / why we need it:
The SMB test keeps failing. It failed at using "ConvertTo-SecureString", this is because the invocation of pwsh -> cmd -> powershell confuse the $env:PSModulePath. After reset its value, this bug is fixed. However, the test still fails at
image

Investigating on how to fix this bug. Bypass the smb test temporarily to unblock integration tests.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Sep 23, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 23, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 23, 2024

Hi @Zhupku. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2024
@mauriciopoppe
Copy link
Member

mauriciopoppe commented Sep 23, 2024

If the test is disabled how do we make sure that we're not adding a regression? I'm aware this is blocking things like #336 but I think we should attempt to fix the setup not just ignore the tests.

@andyzhangx
Copy link
Member

andyzhangx commented Oct 14, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2024
andyzhangx
andyzhangx approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, Zhupku

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@andyzhangx
Copy link
Member

andyzhangx commented Oct 14, 2024

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 14, 2024

@Zhupku: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-csi-proxy-integration 3939e38 link true /test pull-kubernetes-csi-csi-proxy-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andyzhangx
Copy link
Member

andyzhangx commented Oct 14, 2024

@mauriciopoppe there is sth. wrong with the integration tests:
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-csi_csi-proxy/356/pull-kubernetes-csi-csi-proxy-integration/1845716316082671616

shall we merge this PR first?

@mauriciopoppe
Copy link
Member

mauriciopoppe commented Oct 14, 2024

/hold

Yes, the presubmit is failing and I attempted to fix it but I don't know enough about Github Actions to enable the required module #348 (comment).

This PR is disabling the test, I think we should fix the infra to run the test but not disable it.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2024
@mauriciopoppe
Copy link
Member

mauriciopoppe commented Oct 23, 2024

This was a good hint: this is because the invocation of pwsh -> cmd -> powershell confuse the $env:PSModulePath. I wrote shell: powershell to avoid using pwsh in #348 and that seemed to help. Thanks.

@mauriciopoppe
Copy link
Member

mauriciopoppe commented Oct 23, 2024

It'll be fixed in #348.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@gnufied gnufied Awaiting requested review from gnufied

@mauriciopoppe mauriciopoppe Awaiting requested review from mauriciopoppe

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Zhupku @k8s-ci-robot @mauriciopoppe @andyzhangx @ScottZhuMS